Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemorySwappiness on Windows Docker #3187

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Fix MemorySwappiness on Windows Docker #3187

merged 1 commit into from
Sep 11, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Sep 11, 2017

Fixes #3181

// Windows does not support MemorySwap/MemorySwappiness #2193
if runtime.GOOS == "windows" {
hostConfig.MemorySwap = 0
hostConfig.MemorySwappiness = -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have the 0 and -1 switched judging by the API docs here: https://docs.docker.com/engine/api/v1.31/#operation/ContainerUpdate (search for "swappiness")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would wish this was documented better :) I actually brought up a windows server and this is the only config that works. -1 disables snappiness since the valid inputs are 0-100 and MemorySwap has to be 0 as well since there is no support for any swap.

@dadgar dadgar merged commit 1bed4b4 into master Sep 11, 2017
@dadgar dadgar deleted the b-windows-docker branch September 11, 2017 16:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants